Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization logging #1130

Closed
wants to merge 8 commits into from
Closed

Conversation

sumane81
Copy link
Contributor

Project Robyn

Generated logging for visualization classes with prompt below

Task Description

  • Take the provided code and enhance it with comprehensive logging capabilities.

The logging should include:
DEBUG level logs: - Print data entities being processed.

  • Track progress through critical sections of the code. INFO level logs: - Highlight high-level progress milestones.

WARNING and ERROR level logs:

  • Capture detailed error messages for troubleshooting.

Instructions

  • Focus solely on the requested module/file/method within the provided code.
  • Introduce logging statements to meet the specified requirements.
  • Deduplicate any redundant log statements to maintain code efficiency.
  • Do not alter the existing implementation. Do not remove docstring
  • Remove print statements or replace them with logging statements
  • Utilize str method from dataclasses if necessary to log information
  • Add any private methods needed to make objects printable Logging Guidelines
  • Use Python's built-in logging module.
  • logger config is already defined for the project. Just instantiate logger if it is not already there.
  • Use lazy formatting for logging functions
  • Assume data entities have str method implemented.

Code Enhancement Expectations

  • The enhanced code should maintain its original functionality.
  • Logging statements should be strategically placed for optimal debugging and monitoring.
  • The code should remain readable and maintainable. Deliverables The modified Python code with enhanced logging in all methods. A brief explanation of the logging strategy and configuration used.

Evaluation Criteria Correctness: Logging statements accurately capture required information.

Code quality: Enhanced code maintains readability and maintainability.

Logging effectiveness: Logs provide valuable insights for debugging and monitoring.

yu-ya-tanaka and others added 8 commits November 11, 2024 16:17
- Added the robyn_refresh endpoint in robynapi_endpoint.R.
- Added an example to call robyn_refresh in robyn_python_notebook.ipynb.
- Updated write_robynmodel() in python_helper.py to default to outputting JSON to plot_folder if no path is specified.
- Modified variable names.
Bumps [webpack](https://github.com/webpack/webpack) from 5.88.2 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.88.2...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8.
- [Release notes](https://github.com/micromatch/micromatch/releases)
- [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/micromatch@4.0.5...4.0.8)

---
updated-dependencies:
- dependency-name: micromatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.21.0.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… 0 (#1061)

* feat: cleaner decomp_plot() using cols instead of areas + ref line in 0
* fix: sort variables by baseline first & amount of absolute impact + exclude 0 impact from legend/plot
* fix: baseline and then rest of variables
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2024
@sumane81 sumane81 changed the base branch from main to robynpy_release November 12, 2024 06:28
@sumane81 sumane81 closed this Nov 12, 2024
@sumane81 sumane81 deleted the visualization_logging branch November 12, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants