Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[integration/accuracy] enable clustering workflow and fix scalings for accuracy. #1141

Closed
wants to merge 10 commits into from
Closed

[integration/accuracy] enable clustering workflow and fix scalings for accuracy. #1141

wants to merge 10 commits into from

Conversation

alxlyj
Copy link
Contributor

@alxlyj alxlyj commented Nov 15, 2024 •
edited
Loading

Project Robyn

Summary

  • Inputs
    • Fix wrong instantiation on MMMData on all_media.
    • Fix wrong instantiation on window_start and rolling_windows
  • Modeling
    • Added scaling factor to match R's RSSD range
    • Better handling of coefficient unscaling
    • Proper zero effect detection with tolerance
    • Testing and comparisons with R exported data
    • Logger.debugs
    • Corrected R-style standard deviation calculation
    • Added proper scaling of data before lambda calculation

Test Plans

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 15, 2024
@alxlyj alxlyj requested a review from sumane81 November 15, 2024 08:02
@alxlyj alxlyj marked this pull request as ready for review November 15, 2024 08:07
@alxlyj alxlyj changed the title [accuracy] improve accuracy [integration/accuracy] enable clustering workflow and fix scalings. Nov 16, 2024
@alxlyj alxlyj changed the title [integration/accuracy] enable clustering workflow and fix scalings. [integration/accuracy] enable clustering workflow and fix scalings for accuracy. Nov 16, 2024
sumane81
sumane81 reviewed Nov 16, 2024
View reviewed changes
python/src/robyn/modeling/ridge_model_builder_fail_pareto.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove backup/alternate files?

@alxlyj alxlyj force-pushed the accuracy/modeling_pareto_allocator branch from fcef861 to 36067e9 Compare November 19, 2024 20:12
@alxlyj alxlyj marked this pull request as draft November 21, 2024 17:48
@alxlyj alxlyj closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumane81 sumane81 sumane81 left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alxlyj @sumane81 @facebook-github-bot