Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robyn one pager end to end flow for tutorial 1 #1160

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

sumalreddy17
Copy link
Contributor

@sumalreddy17 sumalreddy17 commented Nov 22, 2024

Fix end-to-end one pager generation flow

  • Remove redundant parameter passing
  • Fix method call in plot_one_pager
  • Update type hints and parameters
  • Change List[str] to List[PlotType] for plots parameter
  • Update ClusteringConfig to ClusteredResult
  • Add proper return type hints
  • Improve error handling
  • Add better logging messages
  • Add proper figure return handling

Add single solution selection option

  • Allow passing specific solution_id to plot_one_pager
  • Maintain default top pareto behavior
  • Update documentation with usage examples"

Testing: Verified one pager generation from Robyn class works end-to-end"

Screenshot 2024-11-22 at 10 16 22 AM

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2024
python/src/robyn/robyn.py Outdated Show resolved Hide resolved
Copy link
Contributor

@sumane81 sumane81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@sumalreddy17 sumalreddy17 merged commit f0e6322 into robynpy_release Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants