Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make website page edit links work #362

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

mast4461
Copy link
Contributor

@mast4461 mast4461 commented Apr 4, 2022

Page edit links on the website are currently broken, e.g. this one from the Quick Start page: https://github.com/facebookexperimental/Robyn/docs/quick-start.mdx

Change the Docusaurus editUrl to make the edit links work. With this change, the above example link would change to: https://github.com/facebookexperimental/Robyn/edit/main/website/docs/quick-start.mdx

"The final URL is computed by editUrl + relativeDocPath."
https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-content-docs#editUrl

Edit links on the website are currently broken, e.g. [this one](https://github.com/facebookexperimental/Robyn/docs/quick-start.mdx) from the [Quick Start page](https://facebookexperimental.github.io/Robyn/docs/quick-start/).

Change the Docusaurus `editUrl` to make the edit links work.

> The final URL is computed by `editUrl + relativeDocPath`.
- https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-content-docs#editUrl
@facebook-github-bot
Copy link

Hi @mast4461!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@mast4461 mast4461 changed the title Make website edit links work Make website page edit links work Apr 4, 2022
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 4, 2022
@Leonelsentana Leonelsentana merged commit bf75b28 into facebookexperimental:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants