Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pareto_front.png - Show blue dots on top of grey dots #420

Conversation

andrey-legayev
Copy link
Contributor

Project Robyn

pareto_front.png - sometimes blue dots are almost not visible behind of grey dots.
It happens when running Robyn MMM with calibration input with many iterations (6000) and trials (10).

I've sorted data frame before rendering to render blue dots after grey dots.
See screenshot:

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This change has been tested on internal project.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2022
@laresbernardo laresbernardo self-requested a review June 28, 2022 04:09
@laresbernardo laresbernardo self-assigned this Jun 28, 2022
@laresbernardo laresbernardo merged commit b79de8a into facebookexperimental:main Jun 28, 2022
@laresbernardo
Copy link
Collaborator

@andrey-legayev thanks for this visual improvement. It has been merged with "main" branch now 👍

@andrey-legayev andrey-legayev deleted the pareto-front-with-calibration-fix branch June 28, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants