Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update robyn_response() to receive numeric vector #464

Merged

Conversation

Tomobay
Copy link
Contributor

@Tomobay Tomobay commented Aug 15, 2022

Project Robyn

update robyn_response() to receive numeric vector.
current robyn_response allow to receive numeric value. If we want to get multiple result we needed to run multiple times or loop it. It takes so much time to try it. By allowing numeric vector it will reduce time of getting outputs.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit test of robyn_response().
Tested

  • to allow numeric value and vectors.
  • send error if it is not numeric vector.
  • send error if it has negative value.

Checklist:

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes.
  • Make sure your code lints.

@facebook-github-bot
Copy link

Hi @Tomobay!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 15, 2022
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@laresbernardo
Copy link
Collaborator

Thanks for this PR to improve robyn_response() function. Will merge now.

@laresbernardo laresbernardo self-requested a review August 16, 2022 17:17
@laresbernardo laresbernardo merged commit ce6694f into facebookexperimental:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants