Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect plot_folder value on robyn_refresh #708

Merged

Conversation

richin13
Copy link
Contributor

Project Robyn

The value of plot_folder is not being respected when calling robyn_refresh which results in the original folder being used by default (as described in #649). This PR adjust the code so that plot_folder's value is respected when present.

Fixes #649

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Fork the repo and create your branch from master (latest dev version).
  • If you've changed documentation, run devtools::document(). Should update .Rd files.
  • Ensure all tests pass, run devtools::check(). Should have no notes, no warning, no errors.
  • Make sure your code lints.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2023
@laresbernardo laresbernardo self-requested a review April 25, 2023 20:10
@laresbernardo laresbernardo added the bug Something isn't working label Apr 25, 2023
@laresbernardo laresbernardo merged commit 3317a02 into facebookexperimental:main Apr 25, 2023
@richin13 richin13 deleted the respect_plot_folder branch April 25, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

robyn_refresh assumes default model path
3 participants