Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: winsorize errors with na.rm = TRUE #872 + InputCollect print when no prophet #875

Merged
merged 4 commits into from
Dec 1, 2023
Merged

fix: winsorize errors with na.rm = TRUE #872 + InputCollect print when no prophet #875

merged 4 commits into from
Dec 1, 2023

Conversation

laresbernardo
Copy link
Collaborator

@laresbernardo laresbernardo commented Nov 30, 2023 •
edited
Loading

fix: winsorize errors with na.rm = TRUE #872
fix: InputCollect print when prophet is deactivated

@laresbernardo laresbernardo self-assigned this Nov 30, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 30, 2023
@laresbernardo laresbernardo added the bug Something isn't working label Nov 30, 2023
@gufengzhou
Copy link
Contributor

looks good and pls add the version bump

@laresbernardo
Copy link
Collaborator Author

Yup, done! Reado to approve and merge

@laresbernardo laresbernardo changed the title fix: winsorize errors with na.rm = TRUE #872 fix: winsorize errors with na.rm = TRUE #872 + InputCollect print when no prophet Dec 1, 2023
gufengzhou
gufengzhou approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@gufengzhou gufengzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gufengzhou gufengzhou merged commit 29fbebd into facebookexperimental:main Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gufengzhou gufengzhou gufengzhou approved these changes

Assignees

@laresbernardo laresbernardo

Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laresbernardo @gufengzhou @facebook-github-bot