Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle of small fixes and feats #882

Merged
merged 12 commits into from
Dec 15, 2023
Merged

Bundle of small fixes and feats #882

merged 12 commits into from
Dec 15, 2023

Conversation

laresbernardo
Copy link
Collaborator

@laresbernardo laresbernardo commented Dec 13, 2023

  • docs: added commented examples in demo.R using robyn_hypsbuilder() and robyn_modelselector() functions to build hyperparameters default values and help on visual model selection based on combined metrics criteria (using lares >= 5.2.4 CRAN version)
  • feat: enable ... parameter to let users export additional information into .json files into a new "Extras" element using in robyn_write()
  • feat: new baseline_level parameter for robyn_onepagers() to allow variables aggregations.
  • fix: check_metric_dates() dynamic quiet on robyn_allocator()
  • fix: using robyn_recreate(), ask users to provide 'dt_input' input, and now mention that 'dt_holidays' input is optional

None of the changes or feats change default behaviors nor disrupt past versions.

@laresbernardo laresbernardo self-assigned this Dec 13, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 13, 2023
Copy link
Contributor

@gufengzhou gufengzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my inline comments. thanks!

R/R/clusters.R Outdated Show resolved Hide resolved
demo/demo.R Outdated Show resolved Hide resolved
demo/demo.R Outdated Show resolved Hide resolved
Copy link
Contributor

@gufengzhou gufengzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laresbernardo laresbernardo merged commit 4300767 into facebookexperimental:main Dec 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants