Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bl01: refresh fixes and improvements + others #969

Merged
merged 29 commits into from
May 7, 2024
Merged

bl01: refresh fixes and improvements + others #969

merged 29 commits into from
May 7, 2024

Conversation

laresbernardo
Copy link
Collaborator

@laresbernardo laresbernardo commented May 6, 2024

After testing with few beta users on bl01 branch, it's good to land.

  • fix: several bugs when refreshing with robyn_refresh() - non-existing folders, cluster = FALSE, CSV exports, ts_validation, window_end inherited
  • fix: penalties hyperparameters checked correctly when recreating a model that used penalization
  • fix: similar plotting scales for refresh plots when performance is too large to improve readability (refresh_plots_json())
  • feat: new add_data parameter in robyn_write() to include raw data. When used, dt_input is not required to recreate model
  • feat: improved chain logic on refresh models. If user is not following chained directories but models are available in plot_folder, they will be loaded and used
  • feat: recreate InputCollect when RobynModel-models.json provided (no selected model)

This is still version 3.10.7 but will be CRAN's 3.11.0 if no bugs or issues are reported within a week or so after it lands (@gufengzhou)

@laresbernardo laresbernardo requested a review from gufengzhou May 6, 2024 10:33
@laresbernardo laresbernardo self-assigned this May 6, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 6, 2024
Copy link
Contributor

@gufengzhou gufengzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laresbernardo laresbernardo merged commit 8715f0d into main May 7, 2024
1 check passed
@laresbernardo laresbernardo deleted the bl01 branch June 19, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants