refactor: Consolidate subfield filter definitions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68719054 |
xiaoxmeng
added a commit
to xiaoxmeng/verax
that referenced
this pull request
Jan 27, 2025
…al#2) Summary: X-link: facebookincubator/velox#12184 There are multiple definitions of subfield filters in velox and consolidate them in Filter.h Reviewed By: Yuhta Differential Revision: D68719054
xiaoxmeng
force-pushed
the
export-D68719054
branch
from
a30f23d to
7e9620c
Compare
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Jan 27, 2025
…12184) Summary: X-link: facebookexperimental/verax#2 There are multiple definitions of subfield filters in velox and consolidate them in Filter.h Reviewed By: Yuhta Differential Revision: D68719054
|
This pull request was exported from Phabricator. Differential Revision: D68719054 |
Yuhta
approved these changes
Jan 27, 2025
|
This pull request was exported from Phabricator. Differential Revision: D68719054 |
xiaoxmeng
added a commit
to xiaoxmeng/verax
that referenced
this pull request
Jan 28, 2025
…al#2) Summary: Pull Request resolved: facebookexperimental#2 X-link: facebookincubator/velox#12184 There are multiple definitions of subfield filters in velox and consolidate them in Filter.h Reviewed By: Yuhta Differential Revision: D68719054
xiaoxmeng
force-pushed
the
export-D68719054
branch
from
7e9620c to
d46ed48
Compare
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Jan 28, 2025
…12184) Summary: X-link: facebookexperimental/verax#2 Pull Request resolved: facebookincubator#12184 There are multiple definitions of subfield filters in velox and consolidate them in Filter.h Reviewed By: Yuhta Differential Revision: D68719054
…al#2) Summary: Pull Request resolved: facebookexperimental#2 X-link: facebookincubator/velox#12184 There are multiple definitions of subfield filters in velox and consolidate them in Filter.h Reviewed By: Yuhta Differential Revision: D68719054
|
This pull request was exported from Phabricator. Differential Revision: D68719054 |
xiaoxmeng
force-pushed
the
export-D68719054
branch
from
d46ed48 to
0643662
Compare
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Jan 28, 2025
…12184) Summary: X-link: facebookexperimental/verax#2 Pull Request resolved: facebookincubator#12184 There are multiple definitions of subfield filters in velox and consolidate them in Filter.h Reviewed By: Yuhta Differential Revision: D68719054
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Jan 28, 2025
Summary: X-link: facebookexperimental/verax#2 Pull Request resolved: #12184 There are multiple definitions of subfield filters in velox and consolidate them in Filter.h Reviewed By: Yuhta Differential Revision: D68719054 fbshipit-source-id: 7085c7ad803980d960e32ce4a981bd4a722558e9
|
This pull request has been merged in 2a6fdb8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookincubator/velox#12184
There are multiple definitions of subfield filters in velox and consolidate them in Filter.h
Reviewed By: Yuhta
Differential Revision: D68719054