Remove plugin settings matching old DB key on uninstall #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahidkay-meta
approved these changes
Jan 21, 2025
|
@vahidkay-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@vahidkay-meta merged this pull request in ad9eaeb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset makes sure that both database entries containing the plugin settings are removed when uninstalling the plugin. Previously, only the current setting DB entry was being removed when uninstalling the plugin.
Because the plugin copies values from the old DB entry (
facebook_config) to the new one (facebook_business_extension_config) when being run, the plugin never returns to an "empty" state when reinstalled on a machine that had an older version of the plugin which used thefacebook_configoptions DB key.