Skip to content

Commit

Permalink
Update pytorch_profiler.md to include information about older PyTorch…
Browse files Browse the repository at this point in the history
… versions (#153)

Summary:
- Updates `pytorch_profiler.md` to include information about older PyTorch versions.

Based on [this thread](pytorch/kineto#770), versions below PyTorch 2.0 do not work with the on-demand remote tracing feature in Dynolog.

It would be fruitful to mention this in the README  - currently, we only mention that the latest PyTorch 2.0 release is recommended, and nothing about the older versions.

Since using Dynolog with an older PyTorch version does not result in any kind of error or warning, it may be confusing to the users as to why they don't see the expected functionality. Thus, we can include this in the README since many still use older torch versions.

Pull Request resolved: #153

Reviewed By: sanrise

Differential Revision: D47109756

Pulled By: briancoutinho

fbshipit-source-id: 86d7dedca7cc5968874e95200463783c2425f0af
  • Loading branch information
shradhasehgal authored and facebook-github-bot committed Jul 7, 2023
1 parent 3adf543 commit bb3c3a0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions docs/pytorch_profiler.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ The following instructions walk through:
> Note that these instructions continue to evolve as we add more features to PyTorch profiler and Dynolog.
Please use the latest [PyTorch 2.0 release](https://pytorch.org/get-started/pytorch-2.0/). For more information on obtaining PyTorch nightly see [here](https://pytorch.org/get-started/locally/).
Older versions of PyTorch (< 2.0) are currently not supported.

## On-demand tracing locally
On a local machine you can run Dynolog and use the command line tool to trace your application.
Expand Down

0 comments on commit bb3c3a0

Please sign in to comment.