Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bperf: Do not use BPF_CORE_READ #196

Closed

Conversation

liu-song-6
Copy link
Contributor

Summary:
Use direct BTF access to be faster.

We need bpf_rdonly_cast() here, to cast "struct cgroup_subsys_state *"
to "struct cgroup *"

Reviewed By: anakryiko

Differential Revision: D51837046

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 5, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51837046

liu-song-6 added a commit to liu-song-6/dynolog that referenced this pull request Dec 5, 2023
Summary:

Use direct BTF access to be faster.

We need bpf_rdonly_cast() here, to cast "struct cgroup_subsys_state *"
to "struct cgroup *"

Reviewed By: anakryiko

Differential Revision: D51837046
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51837046

Summary:

While we still need read perf events for all the context switch, we can
skip cgroup walking for idle task.

Reviewed By: anakryiko

Differential Revision: D51837045
Summary:

Use direct BTF access to be faster.

We need bpf_rdonly_cast() here, to cast "struct cgroup_subsys_state *"
to "struct cgroup *"

Reviewed By: anakryiko

Differential Revision: D51837046
liu-song-6 added a commit to liu-song-6/dynolog that referenced this pull request Dec 5, 2023
Summary:

Use direct BTF access to be faster.

We need bpf_rdonly_cast() here, to cast "struct cgroup_subsys_state *"
to "struct cgroup *"

Reviewed By: anakryiko

Differential Revision: D51837046
@liu-song-6 liu-song-6 force-pushed the export-D51837046 branch 2 times, most recently from 4b0839c to 0abee3f Compare December 5, 2023 08:26
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51837046

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51837046

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 2381a5e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants