-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bperf: Do not use BPF_CORE_READ #196
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Dec 5, 2023
This pull request was exported from Phabricator. Differential Revision: D51837046 |
liu-song-6
added a commit
to liu-song-6/dynolog
that referenced
this pull request
Dec 5, 2023
Summary: Use direct BTF access to be faster. We need bpf_rdonly_cast() here, to cast "struct cgroup_subsys_state *" to "struct cgroup *" Reviewed By: anakryiko Differential Revision: D51837046
liu-song-6
force-pushed
the
export-D51837046
branch
from
December 5, 2023 08:00
0bc34e9
to
f12fdb8
Compare
This pull request was exported from Phabricator. Differential Revision: D51837046 |
Summary: While we still need read perf events for all the context switch, we can skip cgroup walking for idle task. Reviewed By: anakryiko Differential Revision: D51837045
Summary: Use direct BTF access to be faster. We need bpf_rdonly_cast() here, to cast "struct cgroup_subsys_state *" to "struct cgroup *" Reviewed By: anakryiko Differential Revision: D51837046
liu-song-6
added a commit
to liu-song-6/dynolog
that referenced
this pull request
Dec 5, 2023
Summary: Use direct BTF access to be faster. We need bpf_rdonly_cast() here, to cast "struct cgroup_subsys_state *" to "struct cgroup *" Reviewed By: anakryiko Differential Revision: D51837046
liu-song-6
force-pushed
the
export-D51837046
branch
2 times, most recently
from
December 5, 2023 08:26
4b0839c
to
0abee3f
Compare
This pull request was exported from Phabricator. Differential Revision: D51837046 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D51837046 |
This pull request has been merged in 2381a5e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Use direct BTF access to be faster.
We need bpf_rdonly_cast() here, to cast "struct cgroup_subsys_state *"
to "struct cgroup *"
Reviewed By: anakryiko
Differential Revision: D51837046