Skip to content

Commit

Permalink
Remove extraneous semicolon from fizz/record/RecordLayer.cpp
Browse files Browse the repository at this point in the history
Summary:
Extraneous semicolons are a code smell and can mask more serious problems. `-Wextra-semi-stmt` finds them.

This diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function).

This file is drawn from a heavy-hitting list, so fixing this problem will allow *many* other files to take advantage of the safety `-Wextra-semi-stmt` offers.

This should be a low-risk diff: if it compiles, it works.

Reviewed By: knekritz

Differential Revision: D51631117

fbshipit-source-id: 37566322440aa3b67896ebcb32a931ac6c203ea7
  • Loading branch information
r-barnes authored and facebook-github-bot committed Nov 30, 2023
1 parent dba99d4 commit 0ca4b77
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fizz/record/RecordLayer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ folly::Optional<Param> ReadRecordLayer::decodeHandshakeMessage(
return parse<KeyUpdate>(std::move(handshakeMsg), std::move(original));
default:
throw std::runtime_error("unknown handshake type");
};
}
}

bool ReadRecordLayer::hasUnparsedHandshakeData() const {
Expand Down

0 comments on commit 0ca4b77

Please sign in to comment.