Skip to content

Commit

Permalink
remove dependency of DefaultCertificateVerifier from FizzClient
Browse files Browse the repository at this point in the history
Summary: Move this dependency to AsyncFizzClient, who needs it. FizzClient now only needs the interface CertificateVerifier

Reviewed By: mingtaoy

Differential Revision: D64203528

fbshipit-source-id: 317a0eafe8ff016b51248943371562c2bd8d4189
  • Loading branch information
Zale Young authored and facebook-github-bot committed Oct 25, 2024
1 parent 6b5785c commit d236cac
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions fizz/client/AsyncFizzClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include <fizz/client/FizzClient.h>
#include <fizz/client/FizzClientContext.h>
#include <fizz/protocol/AsyncFizzBase.h>
#include <fizz/protocol/DefaultCertificateVerifier.h>
#include <fizz/protocol/Exporter.h>
#include <fizz/util/Tracing.h>
#include <folly/io/SocketOptionMap.h>
Expand Down
3 changes: 2 additions & 1 deletion fizz/client/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ cpp_library(
":fizz_client_context",
":protocol",
":psk_cache",
"//fizz/protocol:default_certificate_verifier",
"//fizz/protocol:certificate_verifier",
"//fizz/protocol:fizz_base",
],
)
Expand All @@ -137,6 +137,7 @@ cpp_library(
":fizz_client_context",
":protocol",
"//fizz/protocol:async_fizz_base",
"//fizz/protocol:default_certificate_verifier",
"//fizz/protocol:exporter",
"//fizz/util:tracer",
"//folly/io:socket_option_map",
Expand Down
2 changes: 1 addition & 1 deletion fizz/client/FizzClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#include <fizz/client/ClientProtocol.h>
#include <fizz/client/FizzClientContext.h>
#include <fizz/client/PskCache.h>
#include <fizz/protocol/DefaultCertificateVerifier.h>
#include <fizz/protocol/CertificateVerifier.h>
#include <fizz/protocol/FizzBase.h>

namespace fizz {
Expand Down

0 comments on commit d236cac

Please sign in to comment.