Fix UB in test_ref_as_expected #13
Conversation
|
Hi @saethlin! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Ah. I see. Feel free to make this fix yourself. |
|
Thanks so much for the report, and the thoughtful fix. I'll go ahead and apply a version of this. Much appreciated! |
Summary: From facebookincubator/gazebo#13. Fix up some UB in a test. Reviewed By: dtolnay Differential Revision: D54718707 fbshipit-source-id: 52169c051bc5efd399d0e92f1438e97e7a3d2833
Summary: From facebookincubator/gazebo#13. Fix up some UB in a test. Reviewed By: dtolnay Differential Revision: D54718707 fbshipit-source-id: 52169c051bc5efd399d0e92f1438e97e7a3d2833
Summary: From #13. Fix up some UB in a test. Reviewed By: dtolnay Differential Revision: D54718707 fbshipit-source-id: 52169c051bc5efd399d0e92f1438e97e7a3d2833
|
Fixed as 6ea3db4. |
Rust has Provenance, so this attempt to round-trip a pointer through a
usizeby transmuting it then deallocating through that round-tripped pointer is UB somewhere.I found this error in a crater run: rust-lang/rust#121282 and here is a fix.