Add multi-thread version of normal update to mesh #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63765102 |
Summary: Inspired by D63747584, adding a multi-threaded version of normal update in mesh. Additional Changes: - Clear `facePerVertex_` before updating - Utilize Eigen::Vector::normalize() to potentially optimize SIMD (if available) while maintaining the same behavior (i.e., leaving the vector unchanged when the norm is too small) - Use .noalias() for improved performance. - Prefer using member functions over assignment (e.g., setZero() instead of m = Eigen::Vector3f::Zero()) for better performance. Differential Revision: D63765102
facebook-github-bot
force-pushed
the
export-D63765102
branch
from
7a73ab9 to
cdc2356
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63765102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Inspired by D63747584, adding a multi-threaded version of normal update in mesh.
Additional Changes:
facePerVertex_before updatingDifferential Revision: D63765102