Use alignmend memory for DrJit error functions #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Memory alignment checks were added by D63658278 for both AVX and DrJit implementations, but introduced an error in the AVX implementation where Jacobian pointers were not offset to aligned memory address. Diff fixes issue by using new utility function that computes offset and checks alignment with offset, and also removes alignment check from DrJit implementation since current implementation does not require memory alignment (to be addressed in upper Diff stack). Differential Revision: D64132292
Summary: This diff updates the DrJit implementation of the SIMD error functions to utilize the aligned memory versions of DrJit by correctly offsetting the Jacobian pointer to the aligned memory, similar to the AVX implementations. Differential Revision: D64133416
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64133416 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff updates the DrJit implementation of the SIMD error functions to utilize the aligned memory versions of DrJit by correctly offsetting the Jacobian pointer to the aligned memory, similar to the AVX implementations.
Differential Revision: D64133416