Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Small improvements for iOS wrapper #14

Closed

Conversation

morozkin
Copy link
Contributor

Hi!

Big thanks for open-sourcing such a great project! I made a little changes to the iOS wrapper to make code looks a little bit better and be more clear in terms of nullable objects.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot label Jan 19, 2019
@morozkin morozkin force-pushed the ios_wrapper_improvements branch from af00803 to 2364c16 Compare January 19, 2019 15:42
Copy link
Contributor

@cuva cuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the kind words and your interest in Spectrum, @morozkin!

Few comments inline regarding configuration’s designated initialisers but other than that it's looking good!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cuva has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot PR approved Approved pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants