More mutable properties from vectors (#8737)

Summary:
Pull Request resolved: #8737

Exposing additional mutable properties (indices and valuesVector) from DictionaryVector without requiring a shared pointer (and messing up ref counting).

Reviewed By: Yuhta, pedroerp

Differential Revision: D53693084

fbshipit-source-id: 890002715d15e0382a00efc6eb9da6bb4c7b1401

pyvelox/pyvelox.h

@@ -409,7 +409,9 @@ static void registerTypedVectors(
           [](DictionaryVectorPtr<NativeType> vec) {
             return DictionaryIndices{vec->indices()};
           })
-      .def("values", &DictionaryVector<NativeType>::valueVector);
+      .def("values", [](DictionaryVectorPtr<NativeType> vec) {
+        return vec->valueVector();
+      });
 }
 
 static void addVectorBindings(

velox/vector/BaseVector.h

@@ -623,6 +623,10 @@ class BaseVector {
     VELOX_UNSUPPORTED("Vector is not a wrapper");
   }
 
+  virtual VectorPtr& valueVector() {
+    VELOX_UNSUPPORTED("Vector is not a wrapper");
+  }
+
   virtual BaseVector* loadedVector() {
     return this;
   }

velox/vector/ConstantVector.h

@@ -249,6 +249,10 @@ class ConstantVector final : public SimpleVector<T> {
     return valueVector_;
   }
 
+  VectorPtr& valueVector() override {
+    return valueVector_;
+  }
+
   // Index of the element of the base vector that determines the value of this
   // constant vector.
   vector_size_t index() const {

velox/vector/DictionaryVector.h

@@ -121,10 +121,18 @@ class DictionaryVector : public SimpleVector<T> {
     return indices_;
   }
 
+  inline BufferPtr& indices() {
+    return indices_;
+  }
+
   const VectorPtr& valueVector() const override {
     return dictionaryValues_;
   }
 
+  VectorPtr& valueVector() override {
+    return dictionaryValues_;
+  }
+
   BufferPtr wrapInfo() const override {
     return indices_;
   }

velox/vector/SequenceVector.h

@@ -126,6 +126,10 @@ class SequenceVector : public SimpleVector<T> {
     return sequenceValues_;
   }
 
+  VectorPtr& valueVector() override {
+    return sequenceValues_;
+  }
+
   BufferPtr getSequenceLengths() const {
     return sequenceLengths_;
   }