Re-sync with internal repository #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
michaelbrundage
pushed a commit
that referenced
this pull request
Jun 22, 2021
Co-authored-by: Facebook Community Bot <[email protected]>
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 20, 2021
Summary: After D30550349 (5f44b20) and D30652610 (f1694ef), which introduced `neuralprophet` to Kats, a number of issues arose with the build, mostly stemming from the known issue that `neuralprophet` only supports older `torch` versions (ourownstory/neural_prophet#332). The dependency web was quite complex, as some issues arose from dependencies of dependencies of dependencies. All my solutions are detailed below: 1. The `pip install -r test_requirements.txt` failed as `pip` could not resolve the added dependency complexities from downgrading the required `torch` version in D30884622 (8d0b005). This is a known issue in newer pip versions (pypa/pip#9215), so this diff forces the Github test to use the legacy resolver. 2. `torch>=1.4.0` was still resolving to `torch==1.8.0`, so this diff forces a version downgrade to `torch<1.7.0` which is compatible with `neuralprophet`. 3. Subsequently, the `gpytorch` dependency was failing to install due to it requiring a more recent `torch` version, so this diff downgrades the required `gpytorch` version to `1.2.1` which will still accept `torch==1.6.0`. 4. The newest version of `ax-platform` has `botorch==0.5.1` as a requirement, and this version of `botorch` requires `gpytorch>=1.5.1`, which is incompatible with #3. As such, this diff forces `ax-platform==0.1.18`, which will install `botorch>=0.3.2`, which accepts `gpytorch>=1.2`. 5. Nonetheless, despite #4, sometimes `pip` would still install `botorch==0.5.1`, as it technically satisfies the `ax-platform==0.1.18` requirement of `botorch>=0.3.2`. As such, this diff explicitly adds `botorch==0.3.2` as a dependency and places it before the `ax-platform` installation, ensuring that the correct version of `botorch` is installed, thus allowing the dependencies to resolve. Reviewed By: michaelbrundage Differential Revision: D31044893 fbshipit-source-id: 9152fe04da199dd0061472ea60b302ed3945238f
gopinathcs
pushed a commit
to conversight/Kats
that referenced
this pull request
Sep 19, 2022
* Fixes for boolean na types, typos, na assignments in test cases (facebookresearch#110) (facebookresearch#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Sync from source repo master (facebookresearch#4) * Fixes for boolean na types, typos, na assignments in test cases (facebookresearch#110) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Option to chunk Pandas columnar data load (facebookresearch#117) * Fixes for boolean na types, typos, na assignments in test cases (facebookresearch#110) (facebookresearch#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Add option for chunking a Pandas columnar data load * Fix linting issues * Reorder options * Reorder options * Add ability to authenticate via SAML * Update dependencies * Add ability to authenticate via SAML Update dependencies * Add numba as a requirement * fixup: remove incorrect docstring Co-authored-by: JP <[email protected]>
gopinathcs
pushed a commit
to conversight/Kats
that referenced
this pull request
Sep 19, 2022
* conda: update to cudf 0.15, arrow 0.17.1, pandas 1.1 Replace pandas.util.testing with new pandas.testing * Import Context, IpcMemHandle directly from pyarrow Also update move to arrow.ipc.read_schema (from arrow.read_schema). * Replace implicit conversions to arrow with explicit ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal and external repositories are out of sync. This attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging.