fixing potential bug with dilations, although none of our models use it.

facebookresearch · Mar 31, 2023 · 6e8d7ed · 6e8d7ed
1 parent 2a5c2f7
commit 6e8d7ed
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/encodec/modules/conv.py b/encodec/modules/conv.py
@@ -197,7 +197,8 @@ def forward(self, x):
         kernel_size = self.conv.conv.kernel_size[0]
         stride = self.conv.conv.stride[0]
         dilation = self.conv.conv.dilation[0]
-        padding_total = (kernel_size - 1) * dilation - (stride - 1)
+        kernel_size = (kernel_size - 1) * dilation + 1  # effective kernel size with dilations
+        padding_total = kernel_size - stride
         extra_padding = get_extra_padding_for_conv1d(x, kernel_size, stride, padding_total)
         if self.causal:
             # Left padding for causal