[fix] [FSDP] Make _get_default_cuda_device more robust to modules without params #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
myleott
requested review from
sshleifer and
min-xu-ai
and removed request for
sshleifer
min-xu-ai
reviewed
Apr 14, 2021
| # Wraps children modules based on a different min_num_params | ||
| my_auto_wrap_policy = functools.partial(auto_wrap_policy, min_num_params=1e7) | ||
| self.l2 = auto_wrap(TransformerBlock(), shuold_wrap=my_auto_wrap_policy) | ||
| self.l2 = auto_wrap( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
_get_default_cuda_devicefall back to the current device when the input module doesn't have any parameters.Also fix a small doc issue in auto_wrap.