Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checking with @gahdritz, this is quickly put together but does the line 3 from Algorithm 10 ()
(context is this issue and that one )
It's not obvious to me that openfold does a mean though (see) and I'm not sure that the constraints on the dimensions will be super nice for you (this takes A(s, i) and B(s, i) and return -optionally fused mean over s, else sum over s- A x B (outer product i,j wise)). This is just the FW, checking principles before diving further
TODOs
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.