Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #173, dropout repeatibility / mishandled seeds #175

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Fix #173, dropout repeatibility / mishandled seeds #175

merged 1 commit into from
Jan 7, 2022

Conversation

blefaudeux
Copy link
Contributor

What does this PR do?

Fixes #173, many thanks @tridao for the bug report ! Fix + add a unit test to catch that

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 7, 2022
@blefaudeux blefaudeux merged commit 3000421 into main Jan 7, 2022
@blefaudeux blefaudeux deleted the fix_173 branch January 18, 2022 04:46
xwhan pushed a commit to xwhan/xformers that referenced this pull request Feb 8, 2022
@blefaudeux
[minor][lambda] LRA wrap fix (facebookresearch#175)
b9d4134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dianaml0 dianaml0 dianaml0 approved these changes

@fmassa fmassa Awaiting requested review from fmassa

@jieru-hu jieru-hu Awaiting requested review from jieru-hu

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropout uses the *memory address* of seeds instead of reading seeds from memory
3 participants
@blefaudeux @dianaml0 @facebook-github-bot