Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CI to pytorch 1.13 #521

Merged
merged 19 commits into from
Nov 15, 2022
Merged

Conversation

danthe3rd
Copy link
Contributor

@danthe3rd danthe3rd commented Nov 11, 2022

Stack from ghstack (oldest at bottom):

Closes #515
Closes #514

Note:
static_argnums's argument to memory_efficient_fusion is now removed, so had to update some code

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 11, 2022
ghstack-source-id: 365ee90ccacb8efbf0fdf9c171f1a5984ed1a169
Pull Request resolved: #521
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 11, 2022
Closes #515

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 11, 2022
ghstack-source-id: 0e62337c1286a22299a783a93f802994e32472f9
Pull Request resolved: #521
Closes #515

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 11, 2022
ghstack-source-id: 6a805a32a41eebc581da9a2bd830a6c585344d1f
Pull Request resolved: #521
Closes #515

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 11, 2022
ghstack-source-id: 44fe9ccdb03d82fd9759df801e3f8fd649de535f
Pull Request resolved: #521
Closes #515

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 11, 2022
ghstack-source-id: 41a57440de74e6f335c320af83e7864a2ab7ef67
Pull Request resolved: #521
Closes #515

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 11, 2022
ghstack-source-id: ee2606735e5269371576c4a14d0b0ca14b351d09
Pull Request resolved: #521
Closes #515

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 11, 2022
ghstack-source-id: 2bf496b1630f09fc2ef55428b57a65bc508c4289
Pull Request resolved: #521
Closes #515

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 11, 2022
ghstack-source-id: 58b11782588b736a6b60c0d3cfda321f56c81aec
Pull Request resolved: #521
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@danthe3rd danthe3rd requested review from fmassa and bottler November 11, 2022 23:23
Closes #515

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 12, 2022
ghstack-source-id: a9f72a354635727ddd50f0c2504c2284da0c776d
Pull Request resolved: #521
Closes #515

Note:
`static_argnums`'s argument to `memory_efficient_fusion` is now removed, so had to update some code

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 12, 2022
ghstack-source-id: 4020d3f3e5bc7537c40b30693a88d754c391e0fc
Pull Request resolved: #521
Closes #515

Note:
`static_argnums`'s argument to `memory_efficient_fusion` is now removed, so had to update some code

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 12, 2022
ghstack-source-id: 0061655099ee5ac8c488908084f614e68ed4120e
Pull Request resolved: #521
Closes #515

Note:
`static_argnums`'s argument to `memory_efficient_fusion` is now removed, so had to update some code

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 12, 2022
ghstack-source-id: da3085135eaa341c9298838d34c582532d6d560b
Pull Request resolved: #521
Closes #515

Note:
`static_argnums`'s argument to `memory_efficient_fusion` is now removed, so had to update some code

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 12, 2022
ghstack-source-id: 348e11181da9993d8ff47eb9cb18f0dc4649b7bf
Pull Request resolved: #521
Closes #515
Closes #514

Note:
`static_argnums`'s argument to `memory_efficient_fusion` is now removed, so had to update some code

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 12, 2022
ghstack-source-id: dd8f3c1f41829cfea30b81a52b72cbdb1a70b3e5
Pull Request resolved: #521
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

We will need to get Triton version updated first before merging this, but maybe there is a way of getting this merged before that?

requirements-test.txt Show resolved Hide resolved
requirements-test.txt Outdated Show resolved Hide resolved
Closes #515
Closes #514

Note:
`static_argnums`'s argument to `memory_efficient_fusion` is now removed, so had to update some code

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 14, 2022
ghstack-source-id: ff023193186556b5fcd64188559a239a0f2641da
Pull Request resolved: #521
Closes #515
Closes #514

Note:
`static_argnums`'s argument to `memory_efficient_fusion` is now removed, so had to update some code

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 14, 2022
ghstack-source-id: 8b437ec804256a945660fe165328e65ab39da429
Pull Request resolved: #521
Closes #515
Closes #514

Note:
`static_argnums`'s argument to `memory_efficient_fusion` is now removed, so had to update some code

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 14, 2022
ghstack-source-id: b1df2a4bb493535fbdec481f7246092e380032b6
Pull Request resolved: #521
@codecov-commenter
Copy link

Codecov Report

Base: 87.98% // Head: 87.98% // No change to project coverage 👍

Coverage data is based on head (a582e7a) compared to base (a582e7a).
Patch has no changes to coverable lines.

❗ Current head a582e7a differs from pull request most recent head d689e86. Consider uploading reports for the commit d689e86 to get more accurate results

Additional details and impacted files
@@                  Coverage Diff                  @@
##           gh/danthe3rd/56/base     #521   +/-   ##
=====================================================
  Coverage                 87.98%   87.98%           
=====================================================
  Files                        80       80           
  Lines                      4826     4826           
=====================================================
  Hits                       4246     4246           
  Misses                      580      580           
Flag Coverage Δ
Python 87.98% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Closes #515
Closes #514

Note:
`static_argnums`'s argument to `memory_efficient_fusion` is now removed, so had to update some code

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 15, 2022
ghstack-source-id: 0f0b3fbd00a65af27121dd7e811c5e65176b415e
Pull Request resolved: #521
Closes #515
Closes #514

Note:
`static_argnums`'s argument to `memory_efficient_fusion` is now removed, so had to update some code

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Nov 15, 2022
ghstack-source-id: 473802a854a8c50f96d4e5a1aae86e3771f1e788
Pull Request resolved: #521
@danthe3rd danthe3rd merged commit b686e72 into gh/danthe3rd/56/base Nov 15, 2022
danthe3rd pushed a commit that referenced this pull request Nov 15, 2022
ghstack-source-id: 473802a854a8c50f96d4e5a1aae86e3771f1e788
Pull Request resolved: #521
@danthe3rd danthe3rd deleted the gh/danthe3rd/56/head branch November 15, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants