Fix Detection Rule For Amazon Fire TV #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jishidaaaaa
commented
Jan 5, 2021
| @@ -448,7 +448,7 @@ | |||
| ], [MODEL, [VENDOR, 'Amazon'], [TYPE, TABLET]], [ | |||
| /(sd|kf)[0349hijorstuw]+(\sbuild\/|\)).+silk\//i // Fire Phone | |||
| ], [[MODEL, mapper.str, maps.device.amazon.model], [VENDOR, 'Amazon'], [TYPE, MOBILE]], [ | |||
| /android.+aft([bms])\sbuild/i // Fire TV | |||
| /android.+aft([\w])(\sbuild\/|\))/i // Fire TV | |||
There was a problem hiding this comment.
https://developer.amazon.com/docs/fire-tv/user-agent-strings.html
with a device model that starts with "AFT".
According to the document, It is correct to judge by any single character following "AFT"
There was a problem hiding this comment.
Supports both with and without "build"
jishidaaaaa
commented
Jan 5, 2021
| @@ -1219,6 +1219,15 @@ | |||
| "type": "smarttv" | |||
| } | |||
| }, | |||
| { | |||
| "desc": "Amazon Fire TV", | |||
| "ua": "Mozilla/5.0 (Linux; Android 5.1.1; AFTT) AppleWebKit/537.36 (KHTML, like Gecko) Silk/86.3.20 like Chrome/86.0.4240.198 Safari/537.36", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed because it was not judged correctly in the latest model.