Added support for honor separated from Huawei #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisalman
requested changes
Oct 1, 2024
faisalman
approved these changes
Nov 9, 2024
faisalman
added a commit
that referenced
this pull request
Dec 21, 2024
nanalucky
pushed a commit
to nanalucky/ua-parser-js
that referenced
this pull request
Feb 18, 2025
* Added support for honor separated from Huawei * Revert "Added support for honor separated from Huawei" This reverts commit 28bde1c. * Added changes wrt comments * Added another change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Type of Change
Enhancement - related to #704
Description
Huawei and Honor were assumed to be the same company from the useragent. But honor has now separated into a separate organization, so its parsing needs to be separated off from huawei
Test
All existing test cases have passed, some test cases which earlier gave huawei now give honor
Impact
Some devices which earlier were marked as huawei will now get marked as honor. This can be considered a change since the output of the parser is different for the same set of data
Other Info