new(cmd/driver): driver config namespace from env variable #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Di Pierro <[email protected]>
…nfigmap. Moreover fixes some issues with the k8s config map updater. Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
|
/cc @alacuku |
|
/milestone v0.8.0 |
FedeDP
force-pushed
the
new/driver_config_namespace_env
branch
from
df0175c to
72dc74f
Compare
FedeDP
commented
May 16, 2024
| @@ -108,12 +128,6 @@ func checkFalcoRunsWithDrivers(engineKind string) error { | |||
|
|
|||
| func (o *driverConfigOptions) replaceDriverTypeInFalcoConfig(driverType drivertype.DriverType) error { | |||
| falcoCfgFile := filepath.Clean(filepath.Join(string(os.PathSeparator), "etc", "falco", "falco.yaml")) | |||
| type engineCfg struct { | |||
There was a problem hiding this comment.
Now used from both replaceDriverTypeInFalcoConfig and replaceDriverTypeInK8SConfigMap.
FedeDP
commented
May 16, 2024
| configMap := configMapList.Items[i] | ||
| currEngineKind := configMap.Data[configMapEngineKindKey] | ||
| if err = checkFalcoRunsWithDrivers(currEngineKind); err != nil { | ||
| updated := false |
There was a problem hiding this comment.
Check that at least a configMap was updated, otherwise return error.
Signed-off-by: Federico Di Pierro <[email protected]>
FedeDP
force-pushed
the
new/driver_config_namespace_env
branch
from
72dc74f to
ee4d280
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area cli
What this PR does / why we need it:
This PR enables the
namespaceparameter ofdriver configcommand to be passed asFALCOCTL_DRIVER_CONFIG_NAMESPACEenv variable.Also, it fixes k8s configMap commit code, switching from
PatchtoUpdatecommand.Finally, logs are a little improved.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: