update(driver/config)!: use the same logic to configure engine kind for different enviroments #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or different enviroments When running in kubernetes, falcoctl does not update the falco config map but creates a new specialized config file with the selected engine kind. The command expects the name of the Falco configmap from which to read the Falco configuration. This is needed to avoid conflicts when multiple Falco's are deployed in the same cluster and namespace. Keep in mind that this are breaking changes. Signed-off-by: Aldo Lacuku <[email protected]>
Signed-off-by: Aldo Lacuku <[email protected]>
alacuku
force-pushed
the
kcl/fix-racecondition-configmap
branch
from
d97c5b1 to
774fef3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 6d5008b8c709e324590d091c5307a3f70c91acec
|
alacuku
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area cli
/area tests
What this PR does / why we need it:
When running in kubernetes, falcoctl does not update the falco config map but creates a new
specialized config file with the selected engine kind. The command expects the name of the Falco
configmap from which to read the Falco configuration. This is needed to avoid conflicts when multiple
Falco's are deployed in the same cluster and namespace. Just to let you know, these are breaking changes.
The engine kind on each node could differ based on the kernel capabilities of the node. When the engine kind is set to
autofalcoctl will choose the best engine kind that fits the node where it is running.Which issue(s) this PR fixes:
falcosecurity/charts#695
falcosecurity/driverkit#351
Fixes #
Special notes for your reviewer: