-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Relay State): Use relay state param for redirection after login #118
Open
ghost
wants to merge
2
commits into
fangli:master
Choose a base branch
from
goakshit:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Oct 2, 2019
amitdctm
approved these changes
Oct 2, 2019
Much better than my solution. Hopefully @fangli merges this and publishes a new patch version. |
We're also being hit by this, and would be quite happy to see it get merged in! @fangli do you have any objections to this as a fix to behavior? |
@fangli any reason not to merge? |
amitdctm
approved these changes
Apr 7, 2020
Hello Amit |
ecararus
approved these changes
Apr 8, 2020
nickdnickd
added a commit
to nickdnickd/django-saml2-auth
that referenced
this pull request
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Pass next_url as relay param to
prepare_to_authenticate
which is echoed back as IDP response and can be accessed in POST request from IDP along with SAML RESPONSE.