Allow shortcuts without parameters #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanglingsu
reviewed
Mar 2, 2017
src/main.c
Outdated
| @@ -252,8 +252,8 @@ gboolean vb_load_uri(Client *c, const Arg *arg) | |||
| rp = realpath(path, NULL); | |||
| uri = g_strconcat("file://", rp, NULL); | |||
| free(rp); | |||
| } else if (strchr(path, ' ') || !strchr(path, '.')) { | |||
| /* use a shortcut if path contains spaces or no dot */ | |||
| } else if (!strchr(path, '.')) { | |||
There was a problem hiding this comment.
Is this really needed for the parameter free shortcuts? I've added the strchr(path, ' ') to allow to search for something containing dots like "document.activeElement". This would not work without the check for space.
There was a problem hiding this comment.
You are totally right, my bad. I misinterpreted the condition. I will update the commit.
rti
force-pushed
the
shortcuts_without_parameters
branch
from
813a9c8
to
4860da8
Compare
|
Updated, not removing the check for space anymore. |
|
Tank you! |
|
Could be this also merged into master branch? |
fanglingsu
added a commit
that referenced
this pull request
Mar 3, 2017
|
@aksr I've applied the changes to the master branch too. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides a simple way to allow calling shortcuts without parameters.
I see several positive effects:
Navigate to your favourite pages via shortcuts
Without necessarily going to search there but check the news feed or what so ever.
Compromise for #284
You could now do:
So you would have to define two shortcuts, but basically it allows the workflow @aksr requested.
Compromise for #181
Say you set a duckduckgo short via:
You can now
:open du some search stringas usual. But you can also just:open duwhich will bring you to the duckduckgo front page featuring search suggestions. Several search engines I tested send you to the search front page if the url query was empty. So it's a way to rapidly access search suggestions without vimb implementing it :) Maybe it helps the workflow of @257What do you think?