Merge pull request #192 from lkeegan/pmcx_bc_overflow_error

Fix buffer overflow error when bc has 12 characters
fangq · Oct 3, 2023 · 35170f9 · 35170f9
2 parents 7e75498 + 3c77170
commit 35170f9
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/pmcx.cpp b/src/pmcx.cpp
@@ -723,11 +723,10 @@ void parse_config(const py::dict& user_cfg, Config& mcx_config) {
         std::string bc_string = py::str(user_cfg["bc"]);
 
         if (bc_string.empty() || bc_string.size() > 12) {
-            throw py::value_error("the 'bc' field must be a non-empty string / have less than 12 characters.");
+            throw py::value_error("the 'bc' field must be a non-empty string / have no more than 12 characters.");
         }
 
-        strncpy(mcx_config.bc, bc_string.c_str(), bc_string.size() + 1);
-        mcx_config.bc[bc_string.size()] = '\0';
+        strncpy(mcx_config.bc, bc_string.c_str(), bc_string.size());
     }
 
     if (user_cfg.contains("detphotons")) {