Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay fails when simulating with multiple light sources #215

Closed
shanghongY opened this issue Mar 13, 2024 · 6 comments
Closed

Replay fails when simulating with multiple light sources #215

shanghongY opened this issue Mar 13, 2024 · 6 comments

Comments

@shanghongY
Copy link

When using two Gaussian light sources, there is an error in saving the detected photon ID, and the photon replay function fails to replay all the photons, as shown in the figure. In addition, I also calculated the photon energy absorption, and when using the formula of optical path length and absorption coefficient, the energy absorption of the detected photon is different from the simulation. However, when the same operation is performed with a single light source, the results are correct. Is it possible to solve this problem? Thank you very much.

HP0 $NBGZWZIAU2MXU_@JUW
CT13R9 7$ EPFZG212OOWN](https://github.com/fangq/mcx/assets/163225517/66293a33-2b92-46be-a076-b6bff25cf827) ![EM94(RUI%O~$HH$%(RJ @KC](https://github.com/fangq/mcx/assets/163225517/bee84ff4-9001-46af-b162-5e572885599d) ![VZX2 7_K_YR~5~4U3)@Q8E

@shanghongY
Copy link
Author

CT13R9 7$ EPFZG212O`OWN
EM94(RUI%O~$HH$%(RJ @KC

@fangq
Copy link
Owner

fangq commented Mar 13, 2024

sorry, I do not follow your report, especially the meanings of the circles in Fig. 2 and Fig4. I also do not fully understand what was the error you saw.

can you please edit your report's title, specify what was the issue you are trying to get an answer.

if this involves multiple issues, please describe those in an itemized fashion, providing evidence for each item

@shanghongY shanghongY changed the title Errors occurred when simulating with multiple light sources Replay fails when simulating with multiple light sources Mar 13, 2024
@shanghongY
Copy link
Author

Thank you for your reply. My problem is photon replay failure when simulating with two Gaussian light sources. In the simulation using 10 million photons, 5173 photons are detected by the detector, but only 2598 photons are detected by the photon replay. When calculating the energy absorption of these 5173 photons, it is 92.628% by the formula, and the simulation result is 68.6%. However, when modified to a Gaussian light source, the results are consistent.
5DGVMA%YU`06)NDM(9OFNU1

@shanghongY
Copy link
Author

FIG. 1 and FIG. 2 are the simulation results of photon replay when two Gaussian light sources and a single Gaussian light source are used, respectively. Thank you very much.
0FE) (ML`K~{308A2CYGCEH
20240313120844

@fangq fangq closed this as completed in abdee14 Mar 13, 2024
@fangq
Copy link
Owner

fangq commented Mar 13, 2024

thanks @shanghongY, I got it. I also understood why this happened, and just committed a fix.

please wait for the action script to complete, go download the new binary from here, and test this again, hopefully it is resolved.

@shanghongY
Copy link
Author

Thank you very much for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants