Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1126: Create Sonataflow management console base packages #29

Conversation

fantonangeli
Copy link
Owner

Closes: apache/incubator-kie-issues#1126

@wmedvede, @handreyrc Can you please review this PR?
This is the last PR of the epic, then I will open the PR to upstream/main

Description:
This PR creates the new package sonataflow-management-console-image-env for Image environment variables.
ML: https://lists.apache.org/thread/1c6jt1rkfyw69yoyhkpocj6qyoo6rpn9

Notes:
In packages/sonataflow-management-console-webapp/webpack.config.ts I changed historyApiFallback to false for dev environment only, like in other kie-tools packages, to not allow non-existent URLs like:
http://localhost:9025/nonexistant/#/WorkflowInstances

How to test:
Please follow instruction here: #26

@fantonangeli fantonangeli requested a review from handreyrc August 9, 2024 11:05
…o kie-issues#1126-Create-Sonataflow-management-console-base-packages
@fantonangeli
Copy link
Owner Author

@ricardozanini or @fjtirado can you please review this PR

@fantonangeli fantonangeli merged commit 8c80f40 into kie-issues#1059-EPIC-Sonataflow-management-console Aug 13, 2024
11 checks passed
fantonangeli pushed a commit that referenced this pull request Aug 26, 2024
Sync main branch with Apache main branch
@fantonangeli fantonangeli deleted the kie-issues#1126-Create-Sonataflow-management-console-base-packages branch August 27, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Sonataflow management console base packages
2 participants