-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the map icon svgs #146
Labels
enhancement
New feature or request
Comments
symbioquine
pushed a commit
to symbioquine/farmOS-map
that referenced
this issue
Sep 13, 2022
…rmOS#179 The button designs, while elegant, don't fit with users expectations. First, there's a sense that because the fields are perfectly square, that is a square line drawing tool. So there's hesitancy in using it, and rather people use the line tool instead. The problem is that the line tool does not create an area WKT object, and that produces non-obvious cascading user experience failures down the line (you save something that's should be an area as a line and in FarmOS it doesn't show the acreage... when you export to another service, it fails to render it as an area so the service doesn't work right, etc. etc.). I should also say this doesn't just happen sometimes... it happens a lot. So the design changes offer a few simple things to address these issues: - The main area icons (circle, poly) look filled, and poly icon is not square. All this helps inform the user that this is for creating general purpose areas, helping them not use inappropriate (ie line) solutions. - The 'modify' tool is just more obvious, showing a pointer dragging a corner. It's less elegant than the previous solution, but in our experience users need clarity over elegance in this situation. It's also very similar to the design of this type of function in other solutions, building on what users may have already seen. See previous/related issues; - farmOS#146 - farmOS#152
The current PR for this issue is #179 |
symbioquine
pushed a commit
to symbioquine/farmOS-map
that referenced
this issue
Sep 22, 2022
…rmOS#179 The button designs, while elegant, don't fit with users expectations. First, there's a sense that because the fields are perfectly square, that is a square line drawing tool. So there's hesitancy in using it, and rather people use the line tool instead. The problem is that the line tool does not create an area WKT object, and that produces non-obvious cascading user experience failures down the line (you save something that's should be an area as a line and in FarmOS it doesn't show the acreage... when you export to another service, it fails to render it as an area so the service doesn't work right, etc. etc.). I should also say this doesn't just happen sometimes... it happens a lot. So the design changes offer a few simple things to address these issues: - The main area icons (circle, poly) look filled, and poly icon is not square. All this helps inform the user that this is for creating general purpose areas, helping them not use inappropriate (ie line) solutions. - The 'modify' tool is just more obvious, showing a pointer dragging a corner. It's less elegant than the previous solution, but in our experience users need clarity over elegance in this situation. It's also very similar to the design of this type of function in other solutions, building on what users may have already seen. See previous/related issues; - farmOS#146 - farmOS#152
symbioquine
pushed a commit
that referenced
this issue
Sep 22, 2022
The button designs, while elegant, don't fit with users expectations. First, there's a sense that because the fields are perfectly square, that is a square line drawing tool. So there's hesitancy in using it, and rather people use the line tool instead. The problem is that the line tool does not create an area WKT object, and that produces non-obvious cascading user experience failures down the line (you save something that's should be an area as a line and in FarmOS it doesn't show the acreage... when you export to another service, it fails to render it as an area so the service doesn't work right, etc. etc.). I should also say this doesn't just happen sometimes... it happens a lot. So the design changes offer a few simple things to address these issues: - The main area icons (circle, poly) look filled, and poly icon is not square. All this helps inform the user that this is for creating general purpose areas, helping them not use inappropriate (ie line) solutions. - The 'modify' tool is just more obvious, showing a pointer dragging a corner. It's less elegant than the previous solution, but in our experience users need clarity over elegance in this situation. It's also very similar to the design of this type of function in other solutions, building on what users may have already seen. See previous/related issues; - #146 - #152
#179 has been merged and is included in the latest farmOS-map release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Based on feedback we've got in using the library, the existing icons while clean are not clear enough. I've reviewed these with quite a few people and we ended up on these particular ones.
I'm not 100% sure of the svg structure needed to submit successfully, so someone will need to test this out and report back if it shows the correct green color (I made it black and white basically, assuming the color will get replaced in the browser (?)).
![create-area](https://user-images.githubu
ercontent.com/1742369/160290250-ac19b953-acc9-42b7-82d4-d5e99c58e80e.svg)
The text was updated successfully, but these errors were encountered: