Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Cache obj[key] access into (missed property from PR 707) #759

Merged
merged 1 commit into from
Jan 20, 2025
Merged

perf: Cache obj[key] access into (missed property from PR 707) #759

merged 1 commit into from
Jan 20, 2025

Conversation

cesco69
Copy link
Contributor

@cesco69 cesco69 commented Jan 17, 2025

This PR complete the #707

Caching the value of obj[key] into a variable instead of continue access to object

@mcollina
Copy link
Member

is this improving our benchmarks?

mcollina
mcollina approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cesco69
Copy link
Contributor Author

cesco69 commented Jan 20, 2025

is this improving our benchmarks?

This PR complete some edge case missed by #707 the improvments is neglegible

@mcollina mcollina merged commit 811e716 into fastify:master Jan 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@mcollina mcollina mcollina approved these changes

@ivan-tymoshenko ivan-tymoshenko Awaiting requested review from ivan-tymoshenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cesco69 @mcollina @gurgunday