-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: #5555 - move to node test runner #440
base: master
Are you sure you want to change the base?
test: #5555 - move to node test runner #440
Conversation
I did not move all the tests yet, only the ones under commonjs and typescript esm |
Thanks for your PR.
This plugin is a bit tricky regarding testing, we might discover later then the changes are difficult to apply. |
Got it! So would you prefer that I try to update all the tests in this PR? |
I think it's a good idea, you might want some more reviews before going forward. |
@climba03003 @Fdawgs wdyt? |
since |
I believe we can do incremental one, but it should be green before land.
If you were mentioning |
This reverts commit 71a6660.
Checklist
Moving the tests from
tap
to the node test runner, based on what requested in the following issueFastify #5555
npm run test
andnpm run benchmark
and the Code of conduct