feat: added serverOptions to test helper.js #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing during testing During testing, the log output through stdout is consumed by tap and supressed. To enable logging during testing, the logger needs to be configured to log to stderr. Specifying serverOptions allows to configure the server in the test helper.js
|
If there are issues with the changes, please let me know and I'll address them. |
Eomm
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #546. I've decided to add a
serverOptionsparameter instead of using thepluginOptions.Added an example on how to enable logging during tap testing.
Checklist
npm run testandnpm run benchmarkand the Code of conduct