Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create eject --esm command #566

Merged
merged 2 commits into from
Nov 8, 2022
Merged

create eject --esm command #566

merged 2 commits into from
Nov 8, 2022

Conversation

rommelandrea
Copy link
Contributor

  • create template with server.js esm
  • create test for esm
  • improve test for non esm
  • add help

Implementation for Issue #565

Checklist

@rommelandrea
create eject --esm command
1ebf9be 
- create template with server.js esm
- create test for esm
- improve test for non esm
- add help
@rommelandrea
fix missing [] on test
354e527
mcollina
mcollina approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 426e359 into fastify:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rommelandrea @mcollina