Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a generate-swagger command #567

Merged
merged 4 commits into from
Dec 5, 2022
Merged

Add a generate-swagger command #567

merged 4 commits into from
Dec 5, 2022

Conversation

segevfiner
Copy link
Contributor

@segevfiner segevfiner commented Nov 11, 2022 •
edited
Loading

Fixes #563

cc @mcollina

Checklist

mcollina
mcollina requested changes Nov 12, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

@mcollina
Copy link
Member

CI is failing

@segevfiner segevfiner requested a review from mcollina November 18, 2022 20:18
mcollina
mcollina requested changes Nov 20, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Could you add docs? Then we should be good to go.

mcollina
mcollina approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 1f7d9df into fastify:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command to generate swagger/openapi schema from @fastify/swagger
2 participants
@segevfiner @mcollina