Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all pre-existing upgrade listeners #253

Merged
merged 5 commits into from
Apr 26, 2023
Merged

remove all pre-existing upgrade listeners #253

merged 5 commits into from
Apr 26, 2023

Conversation

mcollina
Copy link
Member

Fixes #249

Checklist

@mcollina mcollina marked this pull request as ready for review April 24, 2023 20:30
index.js Outdated Show resolved Hide resolved
Signed-off-by: Matteo Collina <[email protected]>
Signed-off-by: Matteo Collina <[email protected]>
Signed-off-by: Matteo Collina <[email protected]>
@mcollina
Copy link
Member Author

This is a complete rewrite of the shutdown logic to avoid monkey-patching. It's a semver-major change.
This also includes a behavior change now, as websocket requests received while the server is closing will now receive a 503 like all other requests.

@mcollina mcollina merged commit 206be2f into master Apr 26, 2023
@mcollina mcollina deleted the fix-249 branch April 26, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node server crashes with ERR_INTERNAL_ASSERTION error
3 participants