Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing benchmark script #17

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Add missing benchmark script #17

merged 1 commit into from
Jan 18, 2021

Conversation

denis-sokolov
Copy link
Contributor

PR template mentions running the benchmark script, but it did not exist and I needed to figure out myself how to run benchmarks.

Checklist

mcollina
mcollina approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 56b4ee0 into fastify:master Jan 18, 2021
@denis-sokolov denis-sokolov deleted the benchmark branch January 18, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-sokolov @mcollina @jsumners