Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add safeParse to benchmarks #73

Merged
merged 5 commits into from
Jul 28, 2022
Merged

add safeParse to benchmarks #73

merged 5 commits into from
Jul 28, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jul 28, 2022 •
edited
Loading

Checklist

mcollina
mcollina approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jul 28, 2022

@mcollina

Somehow legacy tests fail. I assume because we did not pin tsd

Uzlopak
Uzlopak commented Jul 28, 2022
View reviewed changes
Copy link
Contributor Author

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont merge yet

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jul 28, 2022

I merge it as the ci cd pipeline works now properly and I got an approval ;)

@Uzlopak Uzlopak merged commit 397ac6d into fastify:master Jul 28, 2022
@Uzlopak Uzlopak deleted the add-benchmark branch July 28, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @mcollina