Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Module attribute and File check #102

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

JuanVqz
Copy link
Member

@JuanVqz JuanVqz commented Jun 9, 2023

Reference #97

Description

This is trying to solve what Ariel found in this comment.

Motivation and Context

How Has This Been Tested?

Screenshots:

I will abide by the code of conduct

This is trying to solve what [Ariel found in this comment.](#97 (comment))

Reference #97
@JuanVqz JuanVqz self-assigned this Jun 9, 2023
@JuanVqz JuanVqz requested a review from a team as a code owner June 9, 2023 04:23
@JuanVqz JuanVqz requested review from mateusdeap, etagwerker and arielj and removed request for a team and mateusdeap June 9, 2023 04:23
@JuanVqz JuanVqz force-pushed the next-method-file-check branch 7 times, most recently from 26e6d17 to fd12e8b Compare June 9, 2023 04:55
@JuanVqz
Copy link
Member Author

JuanVqz commented Jun 9, 2023

I enabled CI for a little bit, and it seems like this is working in Ruby >= 2.5, for Ruby 2.4 there are some issues with the climate_control gem, we can check what is going on with < 2.4 got the same error Ernesto has in his pr.

@JuanVqz
Copy link
Member Author

JuanVqz commented Jun 9, 2023

There is a pr fixing CI #101

Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuanVqz Looks good, thanks!

@etagwerker etagwerker merged commit d825576 into next-method Jun 9, 2023
@etagwerker etagwerker deleted the next-method-file-check branch June 9, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants