Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout of custom field inputs. Now consistent with other form inputs #1239

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

steveyken
Copy link
Member

The size of the inputs on custom fields was larger than the rest of the form. This was related to the introduction of the form-control class for bootstrap forms.

Before this fix:

custom-field-old

After this fix:

Screenshot 2024-02-22 152032

@steveyken
Copy link
Member Author

I do like the layout of the bootstrap fields but reverted here so the entire form is consistent with itself. I'm certainly not opposed to introducing the 'form-control' class more completely and using bootstrap styling but this is beyond the scope of this PR.

@steveyken steveyken requested a review from CloCkWeRX February 22, 2024 07:25
Copy link
Member

@CloCkWeRX CloCkWeRX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, mixed on it as well. Bootstrap makes everything big and tappy. But consistent UI ftw

@CloCkWeRX CloCkWeRX merged commit 9db8fd0 into master Feb 22, 2024
8 checks passed
@steveyken steveyken deleted the fix-custom-field-edit-fields branch February 23, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants