Fix case where entity is updated but the view doesn't refresh #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an entity (such as contact) is editted, and saved. The original view was not being refreshed with changed data. This PR fixes that behaviour.
E.g. If you edit a contact, change the assignee and press 'save', the old assignee is still displayed. This is because the view is not refreshing after update.
Note that this occurred after entity details were moved from the sidebar (which does refresh) into the main view pane.
This solution still uses the decade-old rjs approach. Rails 7 gives us a much nicer Turbo interface for refreshing parts of the page and would bring a significant UI performance improvement. One for the Todo list.