Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support vim8 popup window when run GoDoc #2347

Merged
merged 1 commit into from
Jun 10, 2019
Merged

support vim8 popup window when run GoDoc #2347

merged 1 commit into from
Jun 10, 2019

Conversation

skanehira
Copy link
Contributor

@skanehira skanehira commented Jun 10, 2019

When vim8 has patch patch-8.1.1513 we can use popup window.
set let go_doc_popup_window = 1 and run :GoDoc , document will display on the popup window

image

@skanehira skanehira changed the title support popup window when run GoDoc support vim8 popup window when run GoDoc Jun 10, 2019
@bhcleek
Copy link
Collaborator

bhcleek commented Jun 10, 2019

Thanks. This looks great. The CI tests are failing, but I think it's unrelated. I'll merge this as soon as I can confirm that the failing CI tests aren't at all related.

@bhcleek bhcleek merged commit 74fa8a0 into fatih:master Jun 10, 2019
bhcleek added a commit that referenced this pull request Jun 10, 2019
Update CHANGELOG.md for #2347 and #2351.
@vitaly-zdanevich
Copy link

Is it possible to show this popup on mouse hover, like in ALE?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants