lint: improve golangci-lint interoperability

[pierreN]

Add a new option go_metalinter_use_local_config which disables linters+options for golangci-lint so users can set them on a per project basis via a config file.

golanci-lint errorformat : handle cases when no column number, since when adding some new available linters don't provide a column number

The idea of the PR is to provide the less possible amount of options to golanci-lint so vim-go users can do whatever they want in their yaml config file.

[bhcleek]

Thank you for contributing. Overall, I think this is a nice improvement. I think we can simplify it, though.

Instead of using an option to specify to use the config file, how about not setting --disable-all when the enabled linters is empty? That would simplify this code and give users this same behavior without introducing a new option to manage. 🤔

[bhcleek]

Modify this and other similar changes to be more in line with usual go standards that you may already be familiar with:

let l:default_enabled = ["govet", "golint"]
if go#config#MetalinterUserLocalConfig()
  let l:default_enabled = []
endif

[pierreN]

Instead of using an option to specify to use the config file, how about not setting --disable-all when the enabled linters is empty?

Yes this is indeed better, I was just not sure it was OK to change this behavior. Please have a look at the new diff. Thanks!

[bhcleek]

This looks great. Thank you for simplifying!

I'll merge this after the v1.22 release.

[bhcleek]

@pierreN when trying to resolve some conflicts with master, I inadvertently pushed the wrong branch to your repo. I've created #2715, which is all of your changes rebased onto master. Sorry for the trouble!

[pierreN]

My bad, I should have checked/referenced #2707 in this PR.

Thanks for the merge and for maintaining the awesome vim-go !

[bhcleek]

That was a new PR created since this one. The conflicts were introduced when it was merged; you did everything right.

Thanks again for contributing.